pink-it plugin by modukon · Pull Request #2 · dfarchon/plugins

modukon · 2024-01-29T18:06:44Z

Features:

can automatically destroy all planets inside the pink circle (using dropped bomb from the pink ship)
shows a list of all pink circles in view and their owners/operators
click any planet to see how big a pink circle would be if a bomb was dropped on it

…st of all pink zones and their owners, can be used to plan the dropping of a bomb

netlify · 2024-01-29T18:06:48Z

✅ Deploy Preview for dfares-plugins ready!

Name	Link
🔨 Latest commit	`057ccff`
🔍 Latest deploy log	https://app.netlify.com/sites/dfares-plugins/deploys/65be7361c040190007137dc2
😎 Deploy Preview	https://deploy-preview-2--dfares-plugins.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

deuchainn · 2024-02-02T18:32:43Z

+let lastWorldCoords = null;
+let pzHoveringInList = null;
+
+import { getPlayerColor } from "https://cdn.skypack.dev/@darkforest_eth/procedural";


Suggested change

import { getPlayerColor } from "https://cdn.skypack.dev/@darkforest_eth/procedural";

import { getPlayerColor } from "https://cdn.skypack.dev/@dfares/procedural";

imports should be at the top of the file

import the from @dfares rather than the @darkforest_eth registry.

deuchainn · 2024-02-02T18:35:47Z

+function FullButtonLine(buttons) {
+	let table = document.createElement("table");
+	table.style.textAlign = "center";
+	table.style.width = "100%";
+	table.style.tableLayout = "fixed"; // to make all buttons the same width
+	for (let i=0; i < buttons.length; ++i) {
+		let b = buttons[i];
+		let td = document.createElement("td");
+		let ele = b.element ? b.element : b;
+		ele.style.border =  "1px solid white";
+		ele.style.width = "100%";
+		td.style.width = "100%"; // to make all buttons the same width
+		td.style.padding = "5px";
+		if (i !== 0) td.style.paddingLeft = "0px";
+		td.append(ele);
+		table.append(td);
+	}
+	return table;
+}


Suggested change

function FullButtonLine(buttons) {

let table = document.createElement("table");

table.style.textAlign = "center";

table.style.width = "100%";

table.style.tableLayout = "fixed"; // to make all buttons the same width

for (let i=0; i < buttons.length; ++i) {

let b = buttons[i];

let td = document.createElement("td");

let ele = b.element ? b.element : b;

ele.style.border = "1px solid white";

ele.style.width = "100%";

td.style.width = "100%"; // to make all buttons the same width

td.style.padding = "5px";

if (i !== 0) td.style.paddingLeft = "0px";

td.append(ele);

table.append(td);

}

return table;

}

function FullButtonLine(buttons) {

const table = document.createElement("table");

table.style.textAlign = "center";

table.style.width = "100%";

table.style.tableLayout = "fixed"; // to make all buttons the same width

let first = true;

for (const button of buttons) {

const td = document.createElement("td");

const ele = b.element ? b.element : b;

ele.style.border = "1px solid white";

ele.style.width = "100%";

td.style.width = "100%"; // to make all buttons the same width

td.style.padding = "5px";

if (!first) {

td.style.paddingLeft = "0px";

}

td.append(ele);

table.append(td);

first = false;

}

return table;

}

deuchainn · 2024-02-02T18:36:28Z

+	var tr = document.createElement('tr');
+	for (var str of strArr) {
+		var th = document.createElement('th');


Suggested change

var tr = document.createElement('tr');

for (var str of strArr) {

var th = document.createElement('th');

const tr = document.createElement('tr');

for (const str of strArr) {

const th = document.createElement('th');

deuchainn · 2024-02-02T18:37:15Z

+	var td = document.createElement('td');
+	td.style.border = "1px solid white";
+	td.innerHTML = text;
+	if (width) td.width = width+"px";
+	if (color) td.style.color = color;
+	if (center) td.style["text-align"] = "center";
+	tr.appendChild(td);
+	return td;


Suggested change

var td = document.createElement('td');

td.style.border = "1px solid white";

td.innerHTML = text;

if (width) td.width = width+"px";

if (color) td.style.color = color;

if (center) td.style["text-align"] = "center";

tr.appendChild(td);

return td;

const td = document.createElement('td');

td.style.border = "1px solid white";

td.innerHTML = text;

if (width) td.width = `${width}px`;

if (color) td.style.color = color;

if (center) td.style["text-align"] = "center";

tr.appendChild(td);

return td;

deuchainn · 2024-02-02T18:40:14Z

+}
+function percentToStrHexColor(percent) {


Suggested change

}

function percentToStrHexColor(percent) {

}

function percentToStrHexColor(percent) {

deuchainn · 2024-02-02T18:40:45Z

+}
+function getPlanetRingRadius(planet, multiplier=1.3, min=minDrawPlanetRadius) {


Suggested change

}

function getPlanetRingRadius(planet, multiplier=1.3, min=minDrawPlanetRadius) {

}

function getPlanetRingRadius(planet, multiplier=1.3, min=minDrawPlanetRadius) {

spacing between functions

deuchainn · 2024-02-02T18:44:16Z

+	let radius = viewport.worldToCanvasDist(ui.getRadiusOfPlanetLevel(planet.planetLevel));
+	radius *= multiplier;
+	if (radius < min) radius = min;
+	return radius;


Suggested change

let radius = viewport.worldToCanvasDist(ui.getRadiusOfPlanetLevel(planet.planetLevel));

radius *= multiplier;

if (radius < min) radius = min;

return radius;

const radius = viewport.worldToCanvasDist(ui.getRadiusOfPlanetLevel(planet.planetLevel)) * multiplier;

return radius < min

? min

: radius;

nitpick could be simplifed like this.

deuchainn · 2024-02-02T18:50:42Z

+	let radius = getPlanetRingRadius(planet);
+
+	let animationDuration = 1500;
+	animationDuration *= (1 - level*0.1);
+
+	var millis = Date.now();
+
+	for (var i=0; i<=level; ++i) {
+		drawRingAnimation(ctx, planetX, planetY, radius, millis, animationDuration, color, reverse);
+		millis += animationDuration / (level+1);
+	}


Suggested change

let radius = getPlanetRingRadius(planet);

let animationDuration = 1500;

animationDuration *= (1 - level*0.1);

var millis = Date.now();

for (var i=0; i<=level; ++i) {

drawRingAnimation(ctx, planetX, planetY, radius, millis, animationDuration, color, reverse);

millis += animationDuration / (level+1);

}

const radius = getPlanetRingRadius(planet);

const animationDuration = 1500 * (1 - level * 0.1);

let millis = Date.now();

for (let i = 0; i <= level; ++i) {

drawRingAnimation(ctx, planetX, planetY, radius, millis, animationDuration, color, reverse);

millis += animationDuration / (level+1);

}

both radius and animationDuration are constants that never changed

Don't mind the ++i still the i++ could also be used.

rather use let over var keyword.

deuchainn · 2024-02-02T18:52:27Z

+	let selectedPlanet = ui.getSelectedPlanet();
+//	if (selectedPlanet && pzHoveringInList.locationId === selectedPlanet.locationId) return;


Suggested change

let selectedPlanet = ui.getSelectedPlanet();

// if (selectedPlanet && pzHoveringInList.locationId === selectedPlanet.locationId) return;

The selectedPlanet is not used here for anything.

deuchainn · 2024-02-02T18:52:54Z

+	if (!pzHoveringInList) return;
+	let selectedPlanet = ui.getSelectedPlanet();
+//	if (selectedPlanet && pzHoveringInList.locationId === selectedPlanet.locationId) return;
+	let color = "hsla(300, 100%, 40%, 0.7)";


Suggested change

let color = "hsla(300, 100%, 40%, 0.7)";

const color = "hsla(300, 100%, 40%, 0.7)";

immutable variable here.

deuchainn · 2024-02-02T20:06:14Z

@modukon i created a PR onto your PR here, rather than keep adding minor comments.

chore: cleanup

modukon · 2024-02-03T17:11:34Z

@modukon i created a PR onto your PR here, rather than keep adding minor comments.

i merged it, i hope that worked, if i have to do anything else tell me

deuchainn

LGTM! 🚢 it

deuchainn · 2024-02-03T19:28:28Z

@fromddy looks good to me i don't have permissions to merge but i assume you or @Stx69 can merge?

created pink-it plugin, can automatically destroy planets, shows a li…

6e3fab6

…st of all pink zones and their owners, can be used to plan the dropping of a bomb

PinkIt pinkZone API change adjusting

e9bb05a

deuchainn reviewed Feb 2, 2024

View reviewed changes

deuchainn mentioned this pull request Feb 2, 2024

chore: cleanup modukon/pluginsDFArchon#1

Merged

chore: cleanup

789276a

Merge pull request #1 from deuchainn/modukon

057ccff

chore: cleanup

deuchainn approved these changes Feb 3, 2024

View reviewed changes

cherryblue1024 merged commit 3f3bd20 into dfarchon:main Feb 19, 2024

	import { getPlayerColor } from "https://cdn.skypack.dev/@darkforest_eth/procedural";
	import { getPlayerColor } from "https://cdn.skypack.dev/@dfares/procedural";

		}
		function getPlanetRingRadius(planet, multiplier=1.3, min=minDrawPlanetRadius) {

		let selectedPlanet = ui.getSelectedPlanet();
		// if (selectedPlanet && pzHoveringInList.locationId === selectedPlanet.locationId) return;

	let color = "hsla(300, 100%, 40%, 0.7)";
	const color = "hsla(300, 100%, 40%, 0.7)";

Uh oh!

Conversation

modukon commented Jan 29, 2024

Uh oh!

netlify Bot commented Jan 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for dfares-plugins ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deuchainn commented Feb 2, 2024

Uh oh!

modukon commented Feb 3, 2024

Uh oh!

deuchainn left a comment

Choose a reason for hiding this comment

Uh oh!

deuchainn commented Feb 3, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Jan 29, 2024 •

edited

Loading